fix: treat rule import failures as errors#95
Merged
Conversation
Rule files that fail to import (e.g., missing module resolution) were silently logged as warnings and skipped, causing `archgate check` to report "No rules to check" and exit 0. This masked real configuration errors in CI. Now import failures throw, and the check command catches them and exits with code 1.
Merged
rhuanbarreto
added a commit
that referenced
this pull request
Mar 20, 2026
fix: treat rule import failures as errors instead of warnings Rule files that fail to import (e.g., missing module resolution) were silently logged as warnings and skipped, causing `archgate check` to report "No rules to check" and exit 0. This masked real configuration errors in CI. Now import failures throw, and the check command catches them and exits with code 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archgate/rulesmodule) were silently logged as warnings and skipped, causingarchgate checkto exit 0 with "No rules to check"loadRuleAdrsthrows on import failures instead of swallowing errors, and thecheckcommand catches them and exits with code 1Test plan
bun run validatepassesarchgate checknow exits 1